Skip to content
Jump to bottom

DRY inbound date of birth handler #348

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

DRY inbound date of birth handler #348

wants to merge 1 commit into from
+45 −20

Conversation

Ioannis
Copy link
Contributor

@Ioannis Ioannis commented Oct 26, 2025

No description provided.

@Ioannis Ioannis requested a review from benno October 26, 2025 05:47
@Ioannis Ioannis changed the title DRY inboud date of birth handler DRY inbound date of birth handler Oct 27, 2025
@benno
Copy link
Contributor

benno commented Oct 30, 2025

I'm a little lost here, is this fixing a problem or just refactoring to refactor?

@Ioannis
Copy link
Contributor Author

Ioannis commented Oct 31, 2025

I'm a little lost here, is this fixing a problem or just refactoring to refactor?

@benno

  • Fixes an inbound date-of-birth parsing bug reported by Graeme during Oracle plugin testing; I was able to reproduce and verify the issue.
  • Deduplicates date-of-birth handling across the pipeline, People table, and SQL connector by centralizing it in StringUtilities::handleInboundDateOfBirth, ensuring consistent normalization, reducing duplication, and simplifying maintenance.

@Ioannis Ioannis force-pushed the DRY_dob_handler branch 2 times, most recently from 70e91bd to 4ec8286 Compare November 7, 2025 08:21
Sign in to join this conversation on GitHub.
Reviewers

@benno benno Awaiting requested review from benno

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ioannis @benno